argument parsing: add size to memory argument #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petreeftime
force-pushed
the
memory-units
branch
3 times, most recently
from
dc00847
to
36ad404
Compare
This commit adds an optional size indicator to the memory argument, to simplify declaration of memory. For example, 2G would be equivalent to 2048MiB. The reason to add this is that when using large enclave sizes, such as 2TiB, writing down the actual number requires a calculator. Signed-off-by: Petre Eftime <[email protected]>
belveryin
approved these changes
Sep 28, 2023
belveryin
requested review from
meerd,
eugkoira and
mariusknaust
and removed request for
eugkoira and
mariusknaust
mariusknaust
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an optional size indicator to the memory argument, to
simplify declaration of memory. For example, 2G would be equivalent to
2048MiB. The reason to add this is that when using large enclave sizes,
such as 2TiB, writing down the actual number requires a calculator.
Pending: Looking at making the same change in the allocator, for the same reason.Will update this separately.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.