feat: New param to remove memory limit in invoke #7892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--no-memory-limit` removes the memory limitation in the container during local invoke, even when there's a memory configured in the SAM template.
github-actions
bot
added
area/local/start-api
vicheey
requested changes
Feb 15, 2025
samcli/commands/local/invoke/cli.py
Outdated
| "--no-memory-limit", | ||
| default=False, | ||
| is_flag=True, | ||
| help="Remove the Memory limit during local invoke. This runs the container without the --memory parameter", |
There was a problem hiding this comment.
Are we doing this only for sam local invoke only? I think the issue happens for sam local start-api and sam local start-lambda as well.
The message here is specific to local invoke. Suggesting more generic message:
Remove the memory limit when running Docker container.
There was a problem hiding this comment.
Good point. we might need the same for the other commands. I'll update that, also with a generic message.
vicheey
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--no-memory-limitremoves the memory limitation in the container during local invoke, even when there's a memory configured in the SAM template.Which issue(s) does this change fix?
In certain conditions, Docker fails to run when a memory limit is passed: https://stackoverflow.com/questions/70872355/how-to-resolve-cgroup-error-when-running-docker-container-inside-a-docker-contai
Why is this change necessary?
Allow customers to avoid the Docker issue mentioned above
How does it address the issue?
Add a new parameter so the memory limit is not automatically passed from the template.
What side effects does this change have?
None
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.