-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: S3 add an option to enable/disable "Expect: 100-continue" headers #2783
feat: S3 add an option to enable/disable "Expect: 100-continue" headers #2783
Conversation
The tests fail with the following error which doesn't seem related to the changes introduced in this PR:
|
@trivikr Do you have any idea on why the tests fail even though I have not changed anything related to regions in my PR? |
@ThomasVille there's a whitelist you need to update in |
50e73aa
to
e4cfe03
Compare
Codecov Report
@@ Coverage Diff @@
## master #2783 +/- ##
==========================================
+ Coverage 96.96% 96.96% +<.01%
==========================================
Files 300 300
Lines 8991 8994 +3
Branches 1676 1677 +1
==========================================
+ Hits 8718 8721 +3
Misses 273 273
Continue to review full report at Codecov.
|
e23460c
to
38a96e1
Compare
38a96e1
to
c7de385
Compare
@nullren Thank you for the hint, I had no idea there was such a whitelist of lines to ignore. |
Is this still an active PR? Can the conflicts be merged? |
Since #437, when using Riak-CS v2.1.1 as backend, uploading files larger than 1MB using streams on NodeJS leads to corrupted data stored in Riak-CS.
This PR adds an option to prevent the
Expect: 100-continue
header from being added to the content of the file when uploading a large file.Fixes basho/riak_cs#1327.
Checklist
npm run test
passes.d.ts
file is updatednpm run add-change