Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support numpy 2.0 #2944

Merged
merged 5 commits into from
Aug 28, 2024
Merged

feat: Support numpy 2.0 #2944

merged 5 commits into from
Aug 28, 2024

Conversation

LeonLuttenberger
Copy link
Contributor

Feature or Bugfix

  • Feature

Detail

  • Support numpy 2.0
  • Besides upgrading numpy directly, I had to bump Modin to 0.31.0
  • I override the numpy version when building Lambda layers so that our layers still use 1.x, until we figure out why 2.0 isn't working in AWS Lambda Layers

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 2f72d3a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 2f72d3a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@LeonLuttenberger LeonLuttenberger marked this pull request as ready for review August 27, 2024 20:10
@jaidisido jaidisido linked an issue Aug 28, 2024 that may be closed by this pull request
Support Numpy >= 2.0.0 #2943
Closed
@jaidisido jaidisido merged commit 96790bf into main Aug 28, 2024
22 checks passed
@jaidisido jaidisido deleted the feat/numpy2-support branch August 28, 2024 11:39
kukushking
kukushking reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@adampinky85
Copy link

Great, thank you @LeonLuttenberger & @jaidisido.

Can you release an updated pip package? Many thanks!

@adampinky85 adampinky85 mentioned this pull request Oct 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukushking kukushking kukushking left review comments

@jaidisido jaidisido jaidisido approved these changes

@malachi-constant malachi-constant malachi-constant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Numpy >= 2.0.0
5 participants
@LeonLuttenberger @malachi-constant @adampinky85 @kukushking @jaidisido