fix: Athena read_sql_query cache errors for qmark style parametrized queries #2957
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…ly-wrong-results-for-qmark-style-parametrized-queries-with-cache-enabled
LeonLuttenberger
requested review from
kukushking,
malachi-constant and
jaidisido
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This comment was marked as outdated.
This comment was marked as outdated.
awswrangler/athena/_read.py
Outdated
| @@ -1048,6 +1048,7 @@ def read_sql_query( | |||
| if not client_request_token: | |||
| cache_info: _CacheInfo = _check_for_cached_results( | |||
| sql=sql, | |||
| params=params if paramstyle == "qmark" else None, | |||
There was a problem hiding this comment.
Should we not cache paramstyle="named" parameters as well?
There was a problem hiding this comment.
The named parameters end up built into the SQL query itself client-side. So the query itself contains the values already.
awswrangler/athena/_cache.py
Outdated
| sql=comparable_sql, | ||
| other=parsed_query, | ||
| sql_params=params, | ||
| other_params=query_info.get("ExecutionParameters"), |
There was a problem hiding this comment.
Doesn't this effectively disable caching for qmark queries since parameter values are not returned? https://docs.aws.amazon.com/athena/latest/APIReference/API_QueryExecution.html#athena-Type-QueryExecution-ExecutionParameters "The list of parameters is not returned in the response."
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…ly-wrong-results-for-qmark-style-parametrized-queries-with-cache-enabled
This comment was marked as outdated.
This comment was marked as outdated.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…ly-wrong-results-for-qmark-style-parametrized-queries-with-cache-enabled
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
LeonLuttenberger
deleted the
2956-athena-read_sql_query-provides-completely-wrong-results-for-qmark-style-parametrized-queries-with-cache-enabled
branch
Feature or Bugfix
Detail
read_sql_querycache errors for qmark style parametrized queriesRelates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.