feat: add streaming support on JSON RPC parser #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenfryherrerafeliz
force-pushed
the
feat_json_rpc_impl
branch
2 times, most recently
from
fec21db to
44ba478
Compare
stobrien89
reviewed
Apr 2, 2024
yenfryherrerafeliz
force-pushed
the
feat_json_rpc_impl
branch
5 times, most recently
from
0eff7b3 to
c170035
Compare
yenfryherrerafeliz
force-pushed
the
feat_json_rpc_impl
branch
2 times, most recently
from
9867361 to
76649a2
Compare
stobrien89
requested changes
Apr 18, 2024
src/Api/Parser/NonSeekableStreamDecodingEventStreamIterator.php
Outdated
Show resolved
Hide resolved
src/Api/Parser/NonSeekableStreamDecodingEventStreamIterator.php
Outdated
Show resolved
Hide resolved
yenfryherrerafeliz
force-pushed
the
feat_json_rpc_impl
branch
3 times, most recently
from
927d7fb to
61a7ee8
Compare
stobrien89
approved these changes
May 2, 2024
Just make sure to run the smoke and integ tests. Also, add a changelog entry.
yenfryherrerafeliz
force-pushed
the
feat_json_rpc_impl
branch
from
61a7ee8 to
3cfb632
Compare
yenfryherrerafeliz
changed the title
Add event streaming capabilities on the JSON RPC parser, so that operations such as StartLiveTail from CloudwatchLogs are properly handled/parsed. This change also includes an extension of the DecodingEventStreamIterator for handling streamable responses where the stream as response is not seekable, and a handling for when the `event-type` is `initial-response`.
yenfryherrerafeliz
force-pushed
the
feat_json_rpc_impl
branch
from
3cfb632 to
3697717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add event streaming capabilities on the JSON RPC parser, so that operations such as StartLiveTail from CloudwatchLogs are properly handled/parsed. This change also includes an extension of the DecodingEventStreamIterator for handling streamable responses where the stream as response is not seekable, and a handling for when the
event-typeis `initial-responseIssue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.