feat: track checksum calculation validation mode #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For requests, trackes checksum request calculation, by being either when supported or when required. - For responses, trackers checksum response validation, by being either when supported or when required.
- `response_checksum_validation` metric should be validated just when present in the args.
stobrien89
requested changes
Jan 29, 2025
- Move metrics resolution based on client arguments into the metrics builder class as suggested.
yenfryherrerafeliz
force-pushed
the
feat_track_checksum_calculation_mode
branch
from
6975ade to
7dbf3d8
Compare
yenfryherrerafeliz
requested review from
stobrien89
and removed request for
stobrien89
stobrien89
requested changes
Feb 6, 2025
- Add test cases for `resolveAndAppendFromArgs` method from the metrics builder class. - Refactor a minor code styling in the metrics builder implementation.
yenfryherrerafeliz
force-pushed
the
feat_track_checksum_calculation_mode
branch
from
79faf52 to
b0e57cc
Compare
stobrien89
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.