-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inline completion lang expansion preparation #4884
base: main
Are you sure you want to change the base?
Conversation
testGetProgrammingLanguageUtil<CodeWhispererRuby>(listOf("ruby", "Ruby"), listOf("")) | ||
testGetProgrammingLanguageUtil<CodeWhispererScala>(listOf("scala", "Scala"), listOf("")) | ||
testGetProgrammingLanguageUtil<CodeWhispererSql>(listOf("sql", "Sql"), listOf("")) | ||
// testGetProgrammingLanguageUtil<CodeWhispererCpp>(listOf("c++"), listOf("")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: why these 2 are commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cuz the current implementation doesn't have C/Cpp https://github.com/aws/aws-toolkit-jetbrains/blob/main/plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/language/CodeWhispererLanguageManager.kt#L56-L77. So C/Cpp are purely determined by file extensions for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked the virtualFile.fileType
of .c
and .cpp
file and both fileType show cpp
. So I guess that's the reason why we don't have c and cpp file type condition here in the first place.
{ | ||
"name": "codewhispererLanguage", | ||
"type": "string", | ||
"description": "Programming language of the CodeWhisperer recommendation", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any chance for not using the override?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea i will remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working on telemetry version bump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, have to do it in a separate PR #4900 as there is gumby changes needed to be made
@Rule | ||
@JvmField | ||
val applicationRule = ApplicationRule() | ||
|
||
val suts = listOf( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<depends optional="true" config-file="amazonq-ext-dart.xml">Dart</depends> | ||
<depends optional="true" config-file="amazonq-ext-lua.xml">com.tang</depends> | ||
<depends optional="true" config-file="amazonq-ext-powershell.xml">com.intellij.plugin.adernov.powershell</depends> | ||
<depends optional="true" config-file="amazonq-ext-r.xml">R4Intellij</depends> | ||
<depends optional="true" config-file="amazonq-ext-swift.xml">com.intellij.swift</depends> | ||
<depends optional="true" config-file="amazonq-ext-systemverfilog.xml">studio.edaphic.sv</depends> | ||
<depends optional="true" config-file="amazonq-ext-vue.xml">org.jetbrains.plugins.vue</depends> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alphabetize
Add language which we're going to support within near future. Note that inline completion is still in "disable" and we will turn it on until service is ready.
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.