Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline completion lang expansion preparation #4884

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Sep 16, 2024

Add language which we're going to support within near future. Note that inline completion is still in "disable" and we will turn it on until service is ready.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested review from a team as code owners September 16, 2024 22:54
@Will-ShaoHua Will-ShaoHua marked this pull request as draft September 16, 2024 22:55
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review September 19, 2024 20:48
testGetProgrammingLanguageUtil<CodeWhispererRuby>(listOf("ruby", "Ruby"), listOf(""))
testGetProgrammingLanguageUtil<CodeWhispererScala>(listOf("scala", "Scala"), listOf(""))
testGetProgrammingLanguageUtil<CodeWhispererSql>(listOf("sql", "Sql"), listOf(""))
// testGetProgrammingLanguageUtil<CodeWhispererCpp>(listOf("c++"), listOf(""))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why these 2 are commented out?

Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked the virtualFile.fileType of .c and .cpp file and both fileType show cpp. So I guess that's the reason why we don't have c and cpp file type condition here in the first place.

{
"name": "codewhispererLanguage",
"type": "string",
"description": "Programming language of the CodeWhisperer recommendation",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance for not using the override?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea i will remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on telemetry version bump

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, have to do it in a separate PR #4900 as there is gumby changes needed to be made

@Will-ShaoHua Will-ShaoHua changed the title lang expansion inline completion lang expansion preparation Sep 21, 2024
Comment on lines +207 to +211
@Rule
@JvmField
val applicationRule = ApplicationRule()

val suts = listOf(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 65 to 71
<depends optional="true" config-file="amazonq-ext-dart.xml">Dart</depends>
<depends optional="true" config-file="amazonq-ext-lua.xml">com.tang</depends>
<depends optional="true" config-file="amazonq-ext-powershell.xml">com.intellij.plugin.adernov.powershell</depends>
<depends optional="true" config-file="amazonq-ext-r.xml">R4Intellij</depends>
<depends optional="true" config-file="amazonq-ext-swift.xml">com.intellij.swift</depends>
<depends optional="true" config-file="amazonq-ext-systemverfilog.xml">studio.edaphic.sv</depends>
<depends optional="true" config-file="amazonq-ext-vue.xml">org.jetbrains.plugins.vue</depends>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants