Fix 404 on SSO callback handler #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browsers would attempt to request `favicon.ico` which fail all request chains, leading to fallback to `BuiltInWebServer`/`DefaultWebServerPathHandler`. This would be fine, except the platform webserver respects the browser's `Connection: keep-alive` flag and keep the Netty channel open, and subsequent requests to `.../oauthCallback/...` get handled by `DefaultWebServerPathHandler` and always return 404.
Will-ShaoHua
approved these changes
Sep 27, 2024
6 tasks
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
samgst-amazon
approved these changes
Sep 27, 2024
manodnyab
reviewed
Oct 1, 2024
| @@ -8,6 +8,7 @@ | |||
| <title>AWS Authentication</title> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | |||
| <link rel="stylesheet" type="text/css" media="screen" href="auth.css" /> | |||
| <link rel="icon" href="data:;base64,iVBORw0KGgo="> | |||
There was a problem hiding this comment.
Where does this href lead to?
There was a problem hiding this comment.
its a blank PNG in base64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers would attempt to request
favicon.icowhich fail all request chains, leading to platform fallback toBuiltInWebServer/DefaultWebServerPathHandler.This would be fine, except the platform webserver respects the browser's
Connection: keep-aliveflag and keep sthe Netty channel open, and subsequent requests to.../oauthCallback/...get handled byDefaultWebServerPathHandlerand always return 404.License
I confirm that my contribution is made under the terms of the Apache 2.0 license.