New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feature dev): Add setting to allow Q to run code and test commands #5077

Merged

rli merged 2 commits into aws:feature/dev-execution from willyyhuang:wlsun/add-opt-in-out-for-auto-build

Nov 18, 2024

Contributor

willyyhuang commented Nov 12, 2024 •

edited

Loading

Types of changes

Bug fix (non-breaking change which fixes an issue)
[✅] New feature (non-breaking change which adds functionality)

Description

Q /dev team is launching a new feature: Allow Q to execute build/test based on customer's configuration 🎉🎉

We have made a couple tweaks to incorporate the user experience

Added a new setting to allow Q to run code and test commands per project
Added a pre-filled prompt option for customer to generate a configuration for this feature
Added a couple follow up buttons throughout the /dev flow and added logic around them
Updated copies
Updated codefileExtensions set

Checklist

[✅] My code follows the code style of this project
[🚫] I have added tests to cover my changes
[✅] A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
[🚫] I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

willyyhuang requested review from a team as code owners

November 12, 2024 16:44

willyyhuang force-pushed the wlsun/add-opt-in-out-for-auto-build branch from f83c2e0 to 915e441 Compare

November 12, 2024 16:49

github-advanced-security bot found potential problems

View reviewed changes

...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt Fixed Show fixed Hide fixed

...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt Fixed Show fixed Hide fixed

...software/aws/toolkits/jetbrains/services/codewhisperer/settings/CodeWhispererConfigurable.kt Fixed Show fixed Hide fixed

willyyhuang force-pushed the wlsun/add-opt-in-out-for-auto-build branch 3 times, most recently from bfd5d61 to 5fcc010 Compare

November 13, 2024 15:39

chengoramazon approved these changes

View reviewed changes

rli reviewed

View reviewed changes

...s-community/src/software/aws/toolkits/jetbrains/services/amazonq/FeatureDevSessionContext.kt Outdated Show resolved Hide resolved

...s-community/src/software/aws/toolkits/jetbrains/services/amazonq/FeatureDevSessionContext.kt Show resolved Hide resolved

...software/aws/toolkits/jetbrains/services/codewhisperer/settings/CodeWhispererConfigurable.kt Outdated Show resolved Hide resolved

...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt Show resolved Hide resolved

...munity/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/FeatureDevConstants.kt Outdated Show resolved Hide resolved

willyyhuang force-pushed the wlsun/add-opt-in-out-for-auto-build branch from 5fcc010 to bdceace Compare

November 13, 2024 20:32

github-advanced-security bot found potential problems

View reviewed changes

...software/aws/toolkits/jetbrains/services/codewhisperer/settings/CodeWhispererConfigurable.kt

@@ @@ -113,6 +113,29 @@ @@
                           }
                       }
+                      group(message("aws.settings.codewhisperer.allow_q_dev_build_test_commands")) {

Check warning

Code scanning / QDJVMC

Incorrect string capitalization

String '"Amazon Q: Allow Q /dev to run code and test commands"' is not properly capitalized. It should have title capitalization

willyyhuang force-pushed the wlsun/add-opt-in-out-for-auto-build branch from bdceace to c5559ef Compare

November 13, 2024 21:15

willyyhuang requested a review from rli

November 13, 2024 21:23

github-advanced-security bot found potential problems

View reviewed changes

...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt

+                              messenger.sendAnswer(
+                                  tabId = message.tabId,
+                                  messageType = FeatureDevMessageType.SystemPrompt,
+                                  message = message("amazonqFeatureDev.follow_up.generate_dev_file")

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols

'message(String, vararg Any): String' is deprecated. Use extension-specific localization bundle instead

...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt Fixed Show fixed Hide fixed

...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt Fixed Show fixed Hide fixed

rli reviewed

View reviewed changes

plugins/core/core/build.gradle.kts Outdated Show resolved Hide resolved

plugins/core/core/src/software/aws/toolkits/core/utils/DevFileUtils.kt Outdated Show resolved Hide resolved

willyyhuang force-pushed the wlsun/add-opt-in-out-for-auto-build branch from c5559ef to 5513993 Compare

November 14, 2024 15:25

github-advanced-security bot found potential problems

View reviewed changes

...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt

-                                  ),
+                          val followUps = mutableListOf(
+                              FollowUp(
+                                  pillText = message("amazonqFeatureDev.follow_up.new_task"),

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols

'message(String, vararg Any): String' is deprecated. Use extension-specific localization bundle instead

...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt

+                                  status = FollowUpStatusType.Success
+                              ),
+                              FollowUp(
+                                  pillText = message("amazonqFeatureDev.follow_up.decline_for_project"),

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols

'message(String, vararg Any): String' is deprecated. Use extension-specific localization bundle instead

willyyhuang force-pushed the wlsun/add-opt-in-out-for-auto-build branch 2 times, most recently from 01f72a7 to 5de5fec Compare

November 14, 2024 20:04

willyyhuang requested a review from rli

November 14, 2024 20:54

willyyhuang force-pushed the wlsun/add-opt-in-out-for-auto-build branch 2 times, most recently from 3f86842 to 85f5ec1 Compare

November 18, 2024 15:46


          feat(feature dev): Add setting to allow Q to run code and test commands

7248f19

willyyhuang force-pushed the wlsun/add-opt-in-out-for-auto-build branch from 85f5ec1 to 7248f19 Compare

November 18, 2024 18:08

rli approved these changes

View reviewed changes


          Merge branch 'feature/dev-execution' into wlsun/add-opt-in-out-for-au…

849a274

…to-build

rli merged commit eb22f09 into aws:feature/dev-execution

10 of 12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet