Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow symlinks in chalicelib (resolves #696) #1875

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jessebrennan
Copy link

Resolves issue #696

Follow symlinks when scanning chalicelib directory.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jamesls
Copy link
Member

jamesls commented Jan 25, 2022

Looks good, I'd just like to add a test for this in tests/functinal/test_deployer.py to make sure we don't regress on this functionality.

@jessebrennan
Copy link
Author

@jamesls I wasn't sure from your comment if you planned to do it or were asking me to, but I went ahead and added the test.

I tried to push commits one at a time so that you could see the CI failure with just the test, then pass with the fix, but it looks like they won't run without approval.

Anyway thanks for considering this.

@jessebrennan
Copy link
Author

@jamesls I thought I'd ping you again in case this slipped through the cracks.

@jessebrennan
Copy link
Author

@jamesls I wanted to ping about this PR before it goes stale. Please let me know if you're no longer interested in merging. I added the requested tests.

@mwoodsmall
Copy link

Agree, it would be nice to get this in

@jessebrennan
Copy link
Author

@jamesls is there any interest in merging this still?

@philtrep
Copy link

@jamesls Update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants