Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Local authorizer not respecting header argument passed to it #1977

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

saedx1
Copy link

@saedx1 saedx1 commented Sep 7, 2022

Adds the ability to locally use the authorizer header argument by using the BuiltInAuthConfig attribute in the wrapped authorizer.

Issue #, if available:
#1976 & #1675

Description of changes:
Just changes the code to use the existing config: BuiltInAuthConfig attribute on the built-in local authorizer wrapped function.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adds the ability to locally use the authorizer `header` argument by
using the `BuiltInAuthConfig` attribute in the wrapped authorizer.
@saedx1 saedx1 changed the title Fix local authorizer not respecting header argument passed to it Bug fix: Local authorizer not respecting header argument passed to it Sep 9, 2022
@saedx1
Copy link
Author

saedx1 commented Oct 28, 2022

Can we review this?

@saedx1
Copy link
Author

saedx1 commented Mar 6, 2023

Can we get this going?

@liu-ziyang
Copy link

also supporting the issues and PR here, is there any blocker to get this fix in?

@saedx1
Copy link
Author

saedx1 commented Aug 16, 2023

also supporting the issues and PR here, is there any blocker to get this fix in?

The Blocker is AWS's lack of interest in having quality "open-source" projects. Almost all their things I had to deal with on Github lack care and are really disconnected

@aalvrz
Copy link
Contributor

aalvrz commented Oct 3, 2023

Yep. It doesn't seem like this project has any more interest from AWS to keep it growing. Better switch to CDK or SAM I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants