Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.21] Update to go 1.23 #9382

Open
wants to merge 1 commit into
base: release-0.21
Choose a base branch
from

Conversation

2ez4szliu
Copy link
Member

Manually cherry-picked from #9312

  • Bump controller-gen to v0.17.2 to be compatible with go 1.23
  • Bump golang.org/x/crypto to v0.35.0
  • Bump golangci-lint to v1.64.5 because of timeouts with newer go in older versions

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from 2ez4szliu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@2ez4szliu 2ez4szliu changed the title Update to go 1.23 (#9312) [release-0.21] Update to go 1.23 Mar 4, 2025
@eks-distro-bot eks-distro-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 4, 2025
* Bump controller-gen to v0.17.2 to be compatible with go 1.23
* Bump golang.org/x/crypto to v0.35.0
* Bump golangci-lint to v1.64.5 because of timeouts with newer go in
  older versions
@2ez4szliu 2ez4szliu force-pushed the go-version-1.23-release-0.21 branch from 7844152 to 91f01c7 Compare March 4, 2025 23:25
@eks-distro-bot
Copy link
Collaborator

eks-distro-bot commented Mar 4, 2025

@2ez4szliu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-anywhere-release-tooling-presubmit 91f01c7 link true /test eks-anywhere-release-tooling-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-0.21@1977d54). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-0.21    #9382   +/-   ##
===============================================
  Coverage                ?   69.43%           
===============================================
  Files                   ?      661           
  Lines                   ?    48547           
  Branches                ?        0           
===============================================
  Hits                    ?    33708           
  Misses                  ?    13076           
  Partials                ?     1763           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation documentation size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants