Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove manifests for deprecated csi-secrets-store-provider-aws chart #1167

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Oct 3, 2024

Issue

Description of changes

  • Remove manifests for deprecated csi-secrets-store-provider-aws chart - this was marked as deprecated here in Deprecate secrets-store-csi-driver-aws helm chart hosted here #892 but the manifests were never removed. this now removes those manifests to ensure users refer to the upstream chart definitions
  • Remove note on deprecated Calico chart - this is covered in the EKS documentation

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bryantbiggs bryantbiggs requested a review from dims as a code owner October 3, 2024 14:06
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryantbiggs bryantbiggs merged commit 042326c into aws:master Oct 3, 2024
1 check passed
@bryantbiggs bryantbiggs deleted the chore/remove-deprecated-def branch October 3, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants