Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md for aws-loadbalancer controller #957

Closed
wants to merge 1 commit into from
Closed

Update README.md for aws-loadbalancer controller #957

wants to merge 1 commit into from

Conversation

csantanapr
Copy link

@csantanapr csantanapr commented Jun 12, 2023 •
edited
Loading

Description of changes

Wrong path in aws loadbalancer controller instructions

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

I tested this on EKS with an already install aws lb controoler

alexantoniogonzalez2
alexantoniogonzalez2 approved these changes Jul 8, 2023
View reviewed changes
Copy link

@alexantoniogonzalez2 alexantoniogonzalez2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this is the correct syntax. Please merge.

@bryantbiggs
Copy link
Member

closing as this has since been resolved in #1048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexantoniogonzalez2 alexantoniogonzalez2 alexantoniogonzalez2 approved these changes

@kishorj kishorj Awaiting requested review from kishorj

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh M00nF1sh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csantanapr @bryantbiggs @alexantoniogonzalez2