fix: disable experimental decorator flag #1828
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `experimentalDecorators` flag is legacy from TypeScript 3.9. Since then, decorators have gone through a large change and their new syntax, which is enabled by default in TypeScript 5+, looks very different. Keeping this old flag enabled locks users into old decorator typings which are deprecated, plus because of the way our defaults are applied these flags are not overridable. Instead, don't set `experimentalDecorators` at all, and have users opt in to legacy syntax if they must. This is technically breaking, but I'm pretty sure this will affect such a negligible fraction of users that I think it's worth it.
|
Let's be sure to merge this when we do TypeScript 5.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
experimentalDecoratorsflag is legacy from TypeScript 3.9.Since then, decorators have gone through a large change and their new syntax, which is enabled by default in TypeScript 5+, looks very different.
Keeping this old flag enabled locks users into old decorator typings which are deprecated, plus because of the way our defaults are applied these flags are not overridable.
Instead, don't set
experimentalDecoratorsat all, and have users opt in to legacy syntax if they must.This is technically breaking, but I'm pretty sure this will affect such a negligible fraction of users that I think it's worth it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.