Skip to content

Commit

Permalink
fix: Stop firing conformance testing Notifications (#4927)
Browse files Browse the repository at this point in the history
  • Loading branch information
engedaam authored Oct 25, 2023
1 parent 93484b9 commit 6d4cd28
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/e2e-matrix.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,5 +87,6 @@ jobs:
region: ${{ inputs.region }}
k8s_version: ${{ inputs.k8s_version }}
eksctl_version: ${{ inputs.eksctl_version }}
workflow_trigger: ${{ inputs.workflow_trigger }}
secrets:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
4 changes: 3 additions & 1 deletion .github/workflows/e2e-upgrade.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ on:
eksctl_version:
type: string
default: v0.160.0-rc.0
workflow_trigger:
type: string
secrets:
SLACK_WEBHOOK_URL:
required: true
Expand Down Expand Up @@ -154,7 +156,7 @@ jobs:
CLUSTER_NAME=${{ steps.generate-cluster-name.outputs.CLUSTER_NAME }} INTERRUPTION_QUEUE=${{ steps.generate-cluster-name.outputs.CLUSTER_NAME }} CLUSTER_ENDPOINT="$(aws eks describe-cluster --name ${{ steps.generate-cluster-name.outputs.CLUSTER_NAME }} --query "cluster.endpoint" --output text)" TEST_SUITE="Beta/Integration" make e2etests
- name: notify slack of success or failure
uses: ./.github/actions/e2e/slack/notify
if: (success() || failure()) && github.event_name != 'workflow_run' && github.event_name != 'conformance'
if: (success() || failure()) && github.event_name != 'workflow_run' && inputs.workflow_trigger != 'conformance'
with:
url: ${{ secrets.SLACK_WEBHOOK_URL }}
suite: Upgrade
Expand Down

0 comments on commit 6d4cd28

Please sign in to comment.