Skip to content

Commit

Permalink
Remove limits update from test
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathan-innis committed Aug 2, 2024
1 parent db8ad09 commit 6f8a8d3
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
2 changes: 2 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ require (
sigs.k8s.io/yaml v1.4.0
)

replace sigs.k8s.io/karpenter => github.com/AndrewSirenko/karpenter v0.0.0-20240731005430-e8c5fe73625e

require (
contrib.go.opencensus.io/exporter/ocagent v0.7.1-0.20200907061046-05415f1de66d // indirect
contrib.go.opencensus.io/exporter/prometheus v0.4.2 // indirect
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ contrib.go.opencensus.io/exporter/ocagent v0.7.1-0.20200907061046-05415f1de66d/g
contrib.go.opencensus.io/exporter/prometheus v0.4.2 h1:sqfsYl5GIY/L570iT+l93ehxaWJs2/OwXtiWwew3oAg=
contrib.go.opencensus.io/exporter/prometheus v0.4.2/go.mod h1:dvEHbiKmgvbr5pjaF9fpw1KeYcjrnC1J8B+JKjsZyRQ=
dmitri.shuralyov.com/gpu/mtl v0.0.0-20190408044501-666a987793e9/go.mod h1:H6x//7gZCb22OMCxBHrMx7a5I7Hp++hsVxbQ4BYO7hU=
github.com/AndrewSirenko/karpenter v0.0.0-20240731005430-e8c5fe73625e h1:dYRsc05xN+NXt9bwrv1Jk7cPAiqatn7mxOo+HUxd3Dk=
github.com/AndrewSirenko/karpenter v0.0.0-20240731005430-e8c5fe73625e/go.mod h1:hvnG41Sg3u2hPr7J+Wpve3iHFQXkKt/9VsSgtq2AqpU=
github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym/WlBOVXweHU+Q+/VP0lqqI8lqeDx9IjBqo=
github.com/Masterminds/semver/v3 v3.2.1 h1:RN9w6+7QoMeJVGyfmbcgs28Br8cvmnucEXnY0rYXWg0=
Expand Down Expand Up @@ -761,8 +763,6 @@ sigs.k8s.io/controller-runtime v0.18.4 h1:87+guW1zhvuPLh1PHybKdYFLU0YJp4FhJRmiHv
sigs.k8s.io/controller-runtime v0.18.4/go.mod h1:TVoGrfdpbA9VRFaRnKgk9P5/atA0pMwq+f+msb9M8Sg=
sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd h1:EDPBXCAspyGV4jQlpZSudPeMmr1bNJefnuqLsRAsHZo=
sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd/go.mod h1:B8JuhiUyNFVKdsE8h686QcCxMaH6HrOAZj4vswFpcB0=
sigs.k8s.io/karpenter v0.37.1-0.20240801204017-fcbb8eab6558 h1:pBIbeMg+hvk0PSqcNxpO5HArOBwxC/mNgRdNDc8Fr/U=
sigs.k8s.io/karpenter v0.37.1-0.20240801204017-fcbb8eab6558/go.mod h1:0tyrvPMzL90NMg3Jb0u2cXulPjiI7RCm60BuPUURhlg=
sigs.k8s.io/structured-merge-diff/v4 v4.4.1 h1:150L+0vs/8DA78h1u02ooW1/fFq/Lwr+sGiqlzvrtq4=
sigs.k8s.io/structured-merge-diff/v4 v4.4.1/go.mod h1:N8hJocpFajUSSeSJ9bOZ77VzejKZaXsTtZo4/u7Io08=
sigs.k8s.io/yaml v1.4.0 h1:Mk1wCc2gy/F0THH0TAp1QYyJNzRm2KCLy3o5ASXVI5E=
Expand Down
7 changes: 0 additions & 7 deletions test/suites/storage/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -326,13 +326,6 @@ var _ = Describe("Stateful workloads", func() {

env.EventuallyExpectCreatedNodeCount(">=", 1)

// Set the limit to 0 to make sure we don't continue to create nodeClaims.
// This is CRITICAL since it prevents leaking node resources into subsequent tests
nodePool.Spec.Limits = karpv1.Limits{
corev1.ResourceCPU: resource.MustParse("0"),
}
env.ExpectUpdated(nodePool)

// After the deletion timestamp is set and all pods are drained the node should be gone.
env.EventuallyExpectNotFound(nodeClaim, node)

Expand Down

0 comments on commit 6f8a8d3

Please sign in to comment.