Skip to content

Commit

Permalink
Add documentation.
Browse files Browse the repository at this point in the history
  • Loading branch information
nikmohan committed Mar 15, 2024
1 parent 29af130 commit 890bf73
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions test/suites/scale/provisioning_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,16 +142,16 @@ var _ = Describe("Provisioning", Label(debug.NoWatch), Label(debug.NoEvents), fu
},
},
}

test.ReplaceRequirements(nodePool, corev1beta1.NodeSelectorRequirementWithMinValues{
// minValues is restricted to 30 to have enough instance types to be sent to launch API.
// minValues is restricted to 30 to have enough instance types to be sent to launch API and not make this test flaky.
NodeSelectorRequirement: v1.NodeSelectorRequirement{
Key: v1.LabelInstanceTypeStable,
Operator: v1.NodeSelectorOpExists,
},
MinValues: lo.ToPtr(30),
})

By("waiting for the deployment to deploy all of its pods")
env.ExpectCreated(deployment)
env.EventuallyExpectPendingPodCount(selector, replicas)
Expand Down Expand Up @@ -229,16 +229,16 @@ var _ = Describe("Provisioning", Label(debug.NoWatch), Label(debug.NoEvents), fu
},
},
)

test.ReplaceRequirements(nodePool, corev1beta1.NodeSelectorRequirementWithMinValues{
// minValues is restricted to 30 to have enough instance types to be sent to launch API.
// minValues is restricted to 30 to have enough instance types to be sent to launch API and not make this test flaky.
NodeSelectorRequirement: v1.NodeSelectorRequirement{
Key: v1.LabelInstanceTypeStable,
Operator: v1.NodeSelectorOpExists,
},
MinValues: lo.ToPtr(30),
})

env.MeasureProvisioningDurationFor(func() {
By("waiting for the deployment to deploy all of its pods")
env.ExpectCreated(deployment)
Expand All @@ -258,5 +258,5 @@ var _ = Describe("Provisioning", Label(debug.NoWatch), Label(debug.NoEvents), fu
aws.DeprovisionedNodeCountDimension: strconv.Itoa(0),
aws.PodDensityDimension: strconv.Itoa(replicasPerNode),
})
},SpecTimeout(time.Minute * 30))
}, SpecTimeout(time.Minute*30))
})

0 comments on commit 890bf73

Please sign in to comment.