test: Instance profiles on EC2NodeClass to allow for cleanup (#5000)

aws · Nov 1, 2023 · dcb2843 · dcb2843
1 parent db13430
commit dcb2843
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/test/pkg/environment/aws/environment.go b/test/pkg/environment/aws/environment.go
@@ -110,6 +110,9 @@ func GetTimeStreamAPI(session *session.Session) timestreamwriteiface.TimestreamW
 func (env *Environment) DefaultEC2NodeClass() *v1beta1.EC2NodeClass {
 	nodeClass := test.EC2NodeClass()
 	nodeClass.Spec.AMIFamily = &v1beta1.AMIFamilyAL2
+	nodeClass.Spec.Tags = map[string]string{
+		"testing/cluster": env.ClusterName,
+	}
 	nodeClass.Spec.SecurityGroupSelectorTerms = []v1beta1.SecurityGroupSelectorTerm{
 		{
 			Tags: map[string]string{"karpenter.sh/discovery": env.ClusterName},

diff --git a/test/suites/beta/integration/tags_test.go b/test/suites/beta/integration/tags_test.go
@@ -35,7 +35,7 @@ import (
 var _ = Describe("Tags", func() {
 	Context("Static Tags", func() {
 		It("should tag all associated resources", func() {
-			nodeClass.Spec.Tags = map[string]string{"TestTag": "TestVal"}
+			nodeClass.Spec.Tags["TestTag"] = "TestVal"
 			pod := coretest.Pod()
 
 			env.ExpectCreated(pod, nodeClass, nodePool)
@@ -72,7 +72,7 @@ var _ = Describe("Tags", func() {
 
 		It("shouldn't overwrite custom Name tags", func() {
 			nodeClass = test.EC2NodeClass(*nodeClass, v1beta1.EC2NodeClass{Spec: v1beta1.EC2NodeClassSpec{
-				Tags: map[string]string{"Name": "custom-name"},
+				Tags: map[string]string{"Name": "custom-name", "testing/cluster": env.ClusterName},
 			}})
 			nodePool = coretest.NodePool(*nodePool, corev1beta1.NodePool{
 				Spec: corev1beta1.NodePoolSpec{