Skip to content

Commit

Permalink
failing drift test
Browse files Browse the repository at this point in the history
  • Loading branch information
engedaam committed Aug 7, 2023
1 parent 852eaba commit de86023
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 19 deletions.
12 changes: 0 additions & 12 deletions .github/actions/e2e/create-cluster/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -125,18 +125,6 @@ runs:
wellKnownPolicies:
ebsCSIController: true
EOF
- name: tag oidc provider of the cluster
if: always()
shell: bash
run: |
for arn in $(aws iam list-open-id-connect-providers --query "OpenIDConnectProviderList[*].{ARN:Arn}" --output text); do
tags=$(aws iam list-open-id-connect-provider-tags --open-id-connect-provider-arn $arn --output json)
if [[ $(echo $tags | jq -r '.Tags[] | select(.Key == "alpha.eksctl.io/cluster-name") | .Value') == "${{ inputs.cluster_name }}" ]]; then
aws iam tag-open-id-connect-provider --open-id-connect-provider-arn $arn \
--tags Key=testing.karpenter.sh/type,Value=e2e Key=github.com/run-url,Value=https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}
break
fi
done
- name: give KarpenterNodeRole permission to bootstrap
shell: bash
run: |
Expand Down
16 changes: 9 additions & 7 deletions test/suites/drift/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -267,13 +267,15 @@ var _ = Describe("Drift", Label("AWS"), func() {

// Nodes will need to have the start-up taint removed before the node can be considered as initialized
if fieldName == "Start-up Taint" {
nodes := env.EventuallyExpectCreatedNodeCount("==", 2)
sort.Slice(nodes, func(i int, j int) bool {
return nodes[i].CreationTimestamp.Before(&nodes[j].CreationTimestamp)
})
nodeTwo := nodes[1]
nodeTwo.Spec.Taints = []v1.Taint{}
env.ExpectCreatedOrUpdated(nodeTwo)
Eventually(func(g Gomega) {
nodes := env.EventuallyExpectCreatedNodeCount("==", 2)
sort.Slice(nodes, func(i int, j int) bool {
return nodes[i].CreationTimestamp.Before(&nodes[j].CreationTimestamp)
})
nodeTwo := nodes[1]
nodeTwo.Spec.Taints = []v1.Taint{}
env.ExpectCreatedOrUpdated(nodeTwo)
}).Should(Succeed())
}

env.EventuallyExpectNotFound(pod, node)
Expand Down

0 comments on commit de86023

Please sign in to comment.