Skip to content

Commit

Permalink
ci: revert MNG and SQS diagnostic changes (#5897)
Browse files Browse the repository at this point in the history
  • Loading branch information
jmdeal authored Mar 18, 2024
1 parent 943ea63 commit e5642e0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 20 deletions.
14 changes: 1 addition & 13 deletions .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -172,21 +172,9 @@ jobs:
role: ${{ vars.CI_ROLE_NAME }}
region: ${{ inputs.region }}
cluster_name: ${{ steps.generate-cluster-name.outputs.CLUSTER_NAME }}
# In the case of failure, check if the managed node group is unhealthy. If so, do not clean up cluster for further investigation.
# TODO: @jmdeal remove after investigation is complete
- name: detect unhealthy mng
id: detect-unhealthy-mng
shell: bash
if: failure() || cancelled()
run: |
if ! kubectl get nodes -l eks.amazonaws.com/nodegroup -oyaml | yq ".items[].status.conditions" | grep -q "KubeletNotReady"; then
echo UNHEALTHY="false" >> "$GITHUB_OUTPUT"
else
echo UNHEALTHY="true" >> "$GITHUB_OUTPUT"
fi
- name: cleanup karpenter and cluster '${{ steps.generate-cluster-name.outputs.CLUSTER_NAME }}' resources
uses: ./.github/actions/e2e/cleanup
if: always() && inputs.cleanup && (steps.detect-unhealthy-mng.conclusion == 'skipped' || steps.detect-unhealthy-mng.outputs.UNHEALTHY == 'false')
if: always() && inputs.cleanup
with:
account_id: ${{ vars.CI_ACCOUNT_ID }}
role: ${{ vars.CI_ROLE_NAME }}
Expand Down
5 changes: 1 addition & 4 deletions test/hack/resource/clean/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,7 @@ import (

const sweeperCleanedResourcesTableName = "sweeperCleanedResources"

var excludedClusters = []string{
// TODO: @jmdeal remove after SQS investigation
"soak-periodic-46287782",
}
var excludedClusters = []string{}

func main() {
expiration := flag.String("expiration", "12h", "define the expirationTTL of the resources")
Expand Down
4 changes: 1 addition & 3 deletions test/hack/soak/get_clusters.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ type cluster struct {

const expirationTTL = time.Hour * 168 // 7 days

var excludedClustersCleanup = []string{
"soak-periodic-46287782",
}
var excludedClustersCleanup = []string{}

func main() {
ctx := context.Background()
Expand Down

0 comments on commit e5642e0

Please sign in to comment.