Skip to content

Commit

Permalink
test: Update scale test for expiration to not update expireAfter to p…
Browse files Browse the repository at this point in the history
…revent drift
  • Loading branch information
jigisha620 committed Aug 13, 2024
1 parent c7201b0 commit ffb1980
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/suites/scale/deprovisioning_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -589,6 +589,8 @@ var _ = Describe("Deprovisioning", Label(debug.NoWatch), Label(debug.NoEvents),
nodeClass.Spec.Kubelet = &v1.KubeletConfiguration{
MaxPods: lo.ToPtr[int32](int32(maxPodDensity)),
}
// Enable Expiration
nodePool.Spec.Template.Spec.ExpireAfter.Duration = lo.ToPtr(lo.Must(time.ParseDuration("180s")))

By("waiting for the deployment to deploy all of its pods")
env.ExpectCreated(deployment)
Expand Down Expand Up @@ -616,8 +618,6 @@ var _ = Describe("Deprovisioning", Label(debug.NoWatch), Label(debug.NoEvents),
By("kicking off deprovisioning expiration by setting the ttlSecondsUntilExpired value on the nodePool")
// Change limits so that replacement nodes will use another nodePool.
nodePool.Spec.Limits = disableProvisioningLimits
// Enable Expiration
nodePool.Spec.Template.Spec.ExpireAfter.Duration = lo.ToPtr(time.Duration(0))

noExpireNodePool := test.NodePool(*nodePool.DeepCopy())

Expand Down

0 comments on commit ffb1980

Please sign in to comment.