Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AWSNodeTemplate controller should not produce an error if no securityGroupSelector is specified #3437

Merged
merged 6 commits into from
Feb 22, 2023
Merged

fix: AWSNodeTemplate controller should not produce an error if no securityGroupSelector is specified #3437

merged 6 commits into from
Feb 22, 2023

Commits on Feb 22, 2023

  1. should not error if no securityGroupSelector

    @engedaam
    engedaam committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    4eec65f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-securitygroups-in-launchtemplates

    @engedaam
    engedaam authored Feb 22, 2023
    Configuration menu
    Copy the full SHA
    3d71947 View commit details
    Browse the repository at this point in the history

  3. Wording changes

    @engedaam
    engedaam committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    cc9afba View commit details
    Browse the repository at this point in the history

  4. Clean-up: for failing tests

    @engedaam
    engedaam committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    288883e View commit details
    Browse the repository at this point in the history

  5. Adding test to not error for security groups

    @engedaam
    engedaam committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    c1eb4cd View commit details
    Browse the repository at this point in the history

  6. Wording changes

    @engedaam
    engedaam committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    fb8f9ab View commit details
    Browse the repository at this point in the history