Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add missing colon for karpenter.k8s.aws/instance-generation #4343

Merged
merged 2 commits into from
Jul 28, 2023
Merged

docs: Add missing colon for karpenter.k8s.aws/instance-generation #4343

merged 2 commits into from
Jul 28, 2023

Conversation

shamsher31
Copy link
Contributor

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@shamsher31 shamsher31 requested a review from a team as a code owner July 27, 2023 05:05
@shamsher31 shamsher31 requested a review from engedaam July 27, 2023 05:05
@netlify
Copy link

netlify bot commented Jul 27, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 4595f2c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64c3f2e3924129000823335a
😎 Deploy Preview https://deploy-preview-4343--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jonathan-innis
jonathan-innis approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) July 28, 2023 16:55
@jonathan-innis jonathan-innis merged commit f9056a1 into aws:main Jul 28, 2023
12 checks passed
@shamsher31 shamsher31 deleted the patch-1 branch July 30, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@engedaam engedaam Awaiting requested review from engedaam engedaam is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shamsher31 @jonathan-innis