Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: AWSNodeTemplate Static Drift #4345

Merged
merged 1 commit into from
Aug 2, 2023
Merged

feat: AWSNodeTemplate Static Drift #4345

merged 1 commit into from
Aug 2, 2023

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Jul 27, 2023 •
edited
Loading

Fixes #N/A

Description

  • Adding static one-way drift for the AWSNodeTemplate.
  • The fields that will statically drift:
    • Instance Profile
    • AMI Family
    • UserData
    • Tags
    • Metadata Options
    • Block Device Mappings
    • Detailed Monitoring
    • Context
  • Drift will check the hash that is produced from the AWSNodeTemplate against all its machines to validate the machines have not drifted

How was this change tested?

  • Unit and Integration testing

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Jul 27, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 7b29657
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64ca9a1772eb980009f7c825

jonathan-innis
jonathan-innis reviewed Jul 27, 2023
View reviewed changes
pkg/cloudprovider/suite_test.go Show resolved Hide resolved
pkg/cloudprovider/suite_test.go Outdated Show resolved Hide resolved
pkg/cloudprovider/suite_test.go Show resolved Hide resolved
test/suites/drift/suite_test.go Outdated Show resolved Hide resolved
test/suites/drift/suite_test.go Outdated Show resolved Hide resolved
test/suites/drift/suite_test.go Outdated Show resolved Hide resolved
test/suites/drift/suite_test.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the nodetempalate-static-drift branch 5 times, most recently from 8a09c1d to 199b5e4 Compare July 28, 2023 08:10
@engedaam engedaam marked this pull request as ready for review July 28, 2023 13:52
@engedaam engedaam requested a review from a team as a code owner July 28, 2023 13:52
@engedaam engedaam requested a review from tzneal July 28, 2023 13:52
@engedaam engedaam force-pushed the nodetempalate-static-drift branch 2 times, most recently from 279a615 to fdd59bc Compare July 28, 2023 15:58
jonathan-innis
jonathan-innis reviewed Jul 28, 2023
View reviewed changes
test/suites/drift/suite_test.go Outdated Show resolved Hide resolved
website/content/en/preview/upgrade-guide.md Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the nodetempalate-static-drift branch 2 times, most recently from f8edeb2 to e97206a Compare July 28, 2023 16:28
@engedaam engedaam force-pushed the nodetempalate-static-drift branch 2 times, most recently from bcf7dd5 to e2eade1 Compare July 28, 2023 17:48
jonathan-innis
jonathan-innis previously approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

engedaam
engedaam commented Jul 28, 2023
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-e2eade1dd2fb72873bac4d058ea5a220b043b31c. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

@engedaam engedaam force-pushed the nodetempalate-static-drift branch 5 times, most recently from 869185f to 0a0e414 Compare July 28, 2023 23:27
@engedaam engedaam force-pushed the nodetempalate-static-drift branch 6 times, most recently from ece4377 to c18bfd2 Compare August 2, 2023 01:24
engedaam
engedaam commented Aug 2, 2023
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-c18bfd2602790d1b2440229ba7219cb3e48e3dcc. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

engedaam
engedaam commented Aug 2, 2023
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-a65e95e5f7b2f9603ba0a56c51b75e9ac8066a72. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

engedaam
engedaam commented Aug 2, 2023
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-a65e95e5f7b2f9603ba0a56c51b75e9ac8066a72. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

engedaam
engedaam commented Aug 2, 2023
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-6eabf193bd84c1440bce0453640763e6a6fc3328. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

jonathan-innis
jonathan-innis previously approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

engedaam
engedaam commented Aug 2, 2023
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-983e307cf09edcf8dbcea20d9d014b9e6176f1f0. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

engedaam
engedaam commented Aug 2, 2023
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-7b296571508c8382cc7678c5ac1f0a0e6c5154cc. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

jonathan-innis
jonathan-innis approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 00dd643 into aws:main Aug 2, 2023
13 checks passed
@engedaam engedaam deleted the nodetempalate-static-drift branch August 2, 2023 23:55
@engedaam
Copy link
Contributor Author

Related to #1738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@njtran njtran njtran left review comments

@tzneal tzneal Awaiting requested review from tzneal tzneal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @njtran @jonathan-innis