Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix flaky tests on grabbing CRDs to fast #4351

Merged
merged 1 commit into from
Jul 28, 2023
Merged

test: Fix flaky tests on grabbing CRDs to fast #4351

merged 1 commit into from
Jul 28, 2023

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • The test is grabbing the CRD before the controller hash updated the CRDs with their hash

How was this change tested?

  • Manually tested

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner July 28, 2023 18:33
@engedaam engedaam requested a review from ellistarn July 28, 2023 18:33
@netlify
Copy link

netlify bot commented Jul 28, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 3af6755
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64c40a0c7ecd6300089dfa64

jonathan-innis
jonathan-innis approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam enabled auto-merge (squash) July 28, 2023 18:38
@engedaam engedaam merged commit e46ad0b into aws:main Jul 28, 2023
12 checks passed
@engedaam engedaam deleted the flaky-tests branch July 30, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@ellistarn ellistarn Awaiting requested review from ellistarn ellistarn is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engedaam @jonathan-innis