Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Deny all IMDSv1 to instances #4358

Merged
merged 1 commit into from
Aug 1, 2023
Merged

ci: Deny all IMDSv1 to instances #4358

merged 1 commit into from
Aug 1, 2023

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Aug 1, 2023

Fixes #N/A

Description

  • For the e2e tests, we would like to make sure that the tests do not launch any instance with IMDSv1
  • Needed to remove lines to prevent from hitting the IAM Policy character size limit of 6,144

How was this change tested?

  • Tested in a local account

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner August 1, 2023 06:39
@netlify
Copy link

netlify bot commented Aug 1, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit cdd0be7
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64c8a8af0daa6900071c14ce

jonathan-innis
jonathan-innis approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

@engedaam engedaam merged commit 76fea98 into aws:main Aug 1, 2023
12 checks passed
@engedaam engedaam deleted the deny-IMDSv1-permissions-boundary branch August 1, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engedaam @jonathan-innis