Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Simplify developer guide to use a single ECR repository across multiple projects #4385

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

ellistarn
Copy link
Contributor

Fixes #NA

Description

Simplify dev loop to use a single ECR Repo. Respects existing KO_DOCKER_REPO if set.

How was this change tested?

❯ make apply
2023/08/04 11:40:21 Using base cgr.dev/chainguard/static:latest@sha256:6b35c7e7084349b3a71e70219f61ea49b22d663b89b0ea07474e5b44cbc70860 for github.com/aws/karpenter/cmd/controller
2023/08/04 11:40:22 Building github.com/aws/karpenter/cmd/controller for linux/amd64
2023/08/04 11:40:25 Publishing 767520670908.dkr.ecr.us-west-2.amazonaws.com/dev:latest
2023/08/04 11:40:26 existing blob: sha256:eb0ae35341366ba2c164b0c88e84954fdb05fe9a8bbdf4228f5e7354546a0e6e
2023/08/04 11:40:26 pushed blob: sha256:ee527539410af8964e835a154c6a0166f666d042d876fec78d900ce51d9c6adb
2023/08/04 11:40:26 pushed blob: sha256:747972ef767bf37a2f20f4b744e23dd9d4538c267c5f3668c5b334f45007fbf9
2023/08/04 11:40:26 pushed blob: sha256:6131518f47df0dcb263e6828fbc40e8805d6f3a08d1cfc5144813c9697bcf14a
2023/08/04 11:40:26 pushed blob: sha256:88afcab33c46d90352adfd1be0605b83ba751c86f2c098884dffd4e410a8d938
2023/08/04 11:40:26 767520670908.dkr.ecr.us-west-2.amazonaws.com/dev:sha256-cc60416ab6919762832051e7d0f9cd94f9d7333eb81919e1eb364958f4e25226.sbom: digest: sha256:0eb581b4cc4939be67fe3e40fdbdb830171e4a7420b3516c0e42617d00a1a114 size: 375
2023/08/04 11:40:26 Published SBOM 767520670908.dkr.ecr.us-west-2.amazonaws.com/dev:sha256-cc60416ab6919762832051e7d0f9cd94f9d7333eb81919e1eb364958f4e25226.sbom
2023/08/04 11:40:57 pushed blob: sha256:f7753576870270acebb0f96875ac2c74b7bed1885b5fd2c3e2616161835e7b93
2023/08/04 11:40:57 767520670908.dkr.ecr.us-west-2.amazonaws.com/dev:latest: digest: sha256:cc60416ab6919762832051e7d0f9cd94f9d7333eb81919e1eb364958f4e25226 size: 1212
2023/08/04 11:40:57 Published 767520670908.dkr.ecr.us-west-2.amazonaws.com/dev@sha256:cc60416ab6919762832051e7d0f9cd94f9d7333eb81919e1eb364958f4e25226
helm upgrade --install karpenter charts/karpenter --namespace karpenter \
                --set serviceAccount.annotations.eks\\.amazonaws\\.com/role-arn=arn:aws:iam::767520670908:role/dev-karpenter --set settings.aws.clusterName=dev --set settings.aws.clusterEndpoint=https://188497939A2B3EE4B52405372D342D4E.gr7.us-west-2.eks.amazonaws.com --set settings.aws.defaultInstanceProfile=KarpenterNodeInstanceProfile-dev --set settings.aws.interruptionQueueName=dev --set settings.featureGates.driftEnabled=true --set controller.resources.requests.cpu=1 --set controller.resources.requests.memory=1Gi --set controller.resources.limits.cpu=1 --set controller.resources.limits.memory=1Gi --create-namespace \
                --set controller.image.repository=767520670908.dkr.ecr.us-west-2.amazonaws.com/dev \
                --set controller.image.tag= \
                --set controller.image.digest=sha256:cc60416ab6919762832051e7d0f9cd94f9d7333eb81919e1eb364958f4e25226
walk.go:74: found symbolic link in path: /Users/etarn/go/src/github.com/aws/karpenter/charts/karpenter/crds resolves to /Users/etarn/go/src/github.com/aws/karpenter/pkg/apis/crds. Contents of linked file included and used
Release "karpenter" has been upgraded. Happy Helming!
NAME: karpenter
LAST DEPLOYED: Fri Aug  4 11:40:59 2023
NAMESPACE: karpenter
STATUS: deployed
REVISION: 8
TEST SUITE: None
❯ KO_DOCKER_REPO=767520670908.dkr.ecr.us-west-2.amazonaws.com/karpenter make apply
2023/08/04 11:42:25 Using base cgr.dev/chainguard/static:latest@sha256:6b35c7e7084349b3a71e70219f61ea49b22d663b89b0ea07474e5b44cbc70860 for github.com/aws/karpenter/cmd/controller
2023/08/04 11:42:26 Building github.com/aws/karpenter/cmd/controller for linux/amd64
2023/08/04 11:42:28 Publishing 767520670908.dkr.ecr.us-west-2.amazonaws.com/karpenter:latest
2023/08/04 11:42:29 existing blob: sha256:eb0ae35341366ba2c164b0c88e84954fdb05fe9a8bbdf4228f5e7354546a0e6e
2023/08/04 11:42:29 pushed blob: sha256:ae0543b98b24ec29547a07574c941b786f40e551b071ca8e161ecbc05bfbe9a3
2023/08/04 11:42:29 pushed blob: sha256:351b2a5de6801aac23bc381d946af75eb9cd7c07c44dc14a64c9c8d5e665dd0f
2023/08/04 11:42:29 pushed blob: sha256:88afcab33c46d90352adfd1be0605b83ba751c86f2c098884dffd4e410a8d938
2023/08/04 11:42:29 pushed blob: sha256:45f1ea1c0a081d3c103ab47a181e691bced03e45a1d5f4217be1665910f622d5
2023/08/04 11:42:30 767520670908.dkr.ecr.us-west-2.amazonaws.com/karpenter:sha256-725acd361ab4905c18ba59d5ac8de55dccff98689c23444cd0096454d6956e41.sbom: digest: sha256:f4623796f0258db42cf9c8948e0c521b82742895c3f320b22047e0bdc7510318 size: 375
2023/08/04 11:42:30 Published SBOM 767520670908.dkr.ecr.us-west-2.amazonaws.com/karpenter:sha256-725acd361ab4905c18ba59d5ac8de55dccff98689c23444cd0096454d6956e41.sbom
2023/08/04 11:43:03 pushed blob: sha256:f17b154ab17754992f1f0ad1d079a763dbba756ccbdb09b397b9cfae04298b2b
2023/08/04 11:43:03 767520670908.dkr.ecr.us-west-2.amazonaws.com/karpenter:latest: digest: sha256:725acd361ab4905c18ba59d5ac8de55dccff98689c23444cd0096454d6956e41 size: 1212
2023/08/04 11:43:03 Published 767520670908.dkr.ecr.us-west-2.amazonaws.com/karpenter@sha256:725acd361ab4905c18ba59d5ac8de55dccff98689c23444cd0096454d6956e41
helm upgrade --install karpenter charts/karpenter --namespace karpenter \
                --set serviceAccount.annotations.eks\\.amazonaws\\.com/role-arn=arn:aws:iam::767520670908:role/dev-karpenter --set settings.aws.clusterName=dev --set settings.aws.clusterEndpoint=https://188497939A2B3EE4B52405372D342D4E.gr7.us-west-2.eks.amazonaws.com --set settings.aws.defaultInstanceProfile=KarpenterNodeInstanceProfile-dev --set settings.aws.interruptionQueueName=dev --set settings.featureGates.driftEnabled=true --set controller.resources.requests.cpu=1 --set controller.resources.requests.memory=1Gi --set controller.resources.limits.cpu=1 --set controller.resources.limits.memory=1Gi --create-namespace \
                --set controller.image.repository=767520670908.dkr.ecr.us-west-2.amazonaws.com/karpenter \
                --set controller.image.tag= \
                --set controller.image.digest=sha256:725acd361ab4905c18ba59d5ac8de55dccff98689c23444cd0096454d6956e41
walk.go:74: found symbolic link in path: /Users/etarn/go/src/github.com/aws/karpenter/charts/karpenter/crds resolves to /Users/etarn/go/src/github.com/aws/karpenter/pkg/apis/crds. Contents of linked file included and used
Release "karpenter" has been upgraded. Happy Helming!
NAME: karpenter
LAST DEPLOYED: Fri Aug  4 11:43:05 2023
NAMESPACE: karpenter
STATUS: deployed
REVISION: 9
TEST SUITE: None

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • [] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ellistarn ellistarn requested a review from a team as a code owner August 4, 2023 18:43
@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 2247e74
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64cd476ba012f00008844133

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ellistarn ellistarn merged commit 68af309 into aws:main Aug 4, 2023
12 checks passed
@ellistarn ellistarn deleted the bare branch August 7, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants