Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Flaky Start-up Taint Drift Test #4386

Merged
merged 1 commit into from
Aug 7, 2023
Merged

ci: Flaky Start-up Taint Drift Test #4386

merged 1 commit into from
Aug 7, 2023

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Aug 4, 2023 •
edited
Loading

Fixes #N/A

Description

  • Startup taints seem to be failing due to the node object being changed while e2e test removes start-up taints on the nodes.

How was this change tested?

  • Manually tested

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner August 4, 2023 20:09
@engedaam engedaam requested a review from tzneal August 4, 2023 20:09
@netlify
Copy link

netlify bot commented Aug 4, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 0b7a8a0
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64d1696c32de7a0008dad457

@engedaam engedaam force-pushed the failing-drift-test branch 6 times, most recently from 6e22bd9 to 7aed7ec Compare August 7, 2023 08:51
engedaam
engedaam commented Aug 7, 2023
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-7aed7ec8c2a3c72a967edd341edd81b7995ccef7. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

jonathan-innis
jonathan-innis approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam enabled auto-merge (squash) August 7, 2023 22:05
@engedaam engedaam merged commit 0e0783f into aws:main Aug 7, 2023
12 checks passed
@engedaam engedaam deleted the failing-drift-test branch August 7, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engedaam @jonathan-innis