Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v1beta1 #4744

Merged
merged 6 commits into from
Oct 19, 2023
Merged

feat: v1beta1 #4744

merged 6 commits into from
Oct 19, 2023

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Oct 3, 2023 •
edited
Loading

Fixes #N/A

Description

This PR enables the v1beta1 v1beta1/NodeClass controllers as well as enabling the v1beta1 webhooks into Karpenter.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Oct 3, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 5d24002
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65306c91eff2ed0008b768b9
😎 Deploy Preview https://deploy-preview-4744--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jonathan-innis
jonathan-innis commented Oct 12, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-8d4e4f27bf4013c18037feeafc8f904a48b4fe72.

jonathan-innis
jonathan-innis commented Oct 12, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-494296e32c2a9e9d4713c9911e4e891dc1e9f619.

jonathan-innis
jonathan-innis commented Oct 17, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-9c5e801d030c791531480a33422de9ad458ebb36.

jonathan-innis
jonathan-innis commented Oct 17, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-01c54cffe0d77a56c6aa4d797da1353f96577867.

@jonathan-innis jonathan-innis marked this pull request as ready for review October 18, 2023 05:27
@jonathan-innis jonathan-innis requested a review from a team as a code owner October 18, 2023 05:27
@jonathan-innis jonathan-innis enabled auto-merge (squash) October 18, 2023 05:29
njtran
njtran reviewed Oct 18, 2023
View reviewed changes
cmd/controller/main.go Show resolved Hide resolved
hack/docs/configuration_gen_docs.go Show resolved Hide resolved
pkg/providers/instance/instance.go Show resolved Hide resolved
pkg/webhooks/webhooks.go Show resolved Hide resolved
website/content/en/preview/reference/metrics.md Outdated Show resolved Hide resolved
jonathan-innis
jonathan-innis commented Oct 18, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-5d2400283f68e76277768b774d230f95b46336aa.

@jonathan-innis jonathan-innis merged commit 315ff23 into aws:main Oct 19, 2023
25 of 26 checks passed
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
@jonathan-innis @johngmyers
feat: v1beta1 (aws#4744)
d42297c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@gtomolillo gtomolillo gtomolillo left review comments

@njtran njtran njtran approved these changes

@ellistarn ellistarn Awaiting requested review from ellistarn ellistarn is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathan-innis @gtomolillo @njtran @sftim