Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Enable control plane logging for e2e tests #4846

Merged
merged 2 commits into from
Oct 17, 2023
Merged

ci: Enable control plane logging for e2e tests #4846

merged 2 commits into from
Oct 17, 2023

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Oct 17, 2023 •
edited
Loading

Fixes #N/A

Description

This PR updates the create-cluster.yaml action to create clusters with log retention enabled for 30d.

How was this change tested?

/karepenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Oct 17, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 85cd006
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/652ee2c04bab870008674d2b
😎 Deploy Preview https://deploy-preview-4846--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jonathan-innis
jonathan-innis commented Oct 17, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-b4d4ea330f727ca1d1abb595655557cca5845f9a.

jonathan-innis
jonathan-innis commented Oct 17, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-af097865b5d97d785f8318e5dcddd307967754bc.

@jonathan-innis jonathan-innis force-pushed the enable-control-plane-logging-e2e branch 3 times, most recently from 655ff10 to 46b9369 Compare October 17, 2023 16:01
jonathan-innis
jonathan-innis commented Oct 17, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-46b9369a6eeca4202f8afa249c83fc484462132c.

@jonathan-innis jonathan-innis force-pushed the enable-control-plane-logging-e2e branch 2 times, most recently from e2011da to 4ff3288 Compare October 17, 2023 16:32
jonathan-innis
jonathan-innis commented Oct 17, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-4ff32883a13bad03256466044311c7f665eb6cd1.

@jonathan-innis jonathan-innis marked this pull request as ready for review October 17, 2023 17:36
@jonathan-innis jonathan-innis requested a review from a team as a code owner October 17, 2023 17:36
jonathan-innis
jonathan-innis commented Oct 17, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

njtran
njtran previously approved these changes Oct 17, 2023
View reviewed changes
@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-4ff32883a13bad03256466044311c7f665eb6cd1.

@jonathan-innis jonathan-innis enabled auto-merge (squash) October 17, 2023 19:39
@jonathan-innis jonathan-innis merged commit effb39f into aws:main Oct 17, 2023
11 checks passed
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
@jonathan-innis @johngmyers
ci: Enable control plane logging for e2e tests (aws#4846)
0e78ed5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathan-innis @njtran