You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-e191bd625e03b78245aa5b731ccfb7338561204c.
Nice work! Just a few things about naming 🎉 Does anything change in this PR that we need to test? Should we validate that we still have an AZ with an offering attached to an instance type even if the subnet doesn't support the AZ now? It may also be good to contrive a test that replicates the drift behavior failure that we were seeing so that we ensure that we've solved this problem.
Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-579c8bb1ffd22daa0064da841b39fa6faf399e87.
Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-84cb0b47dabac2240fac749d85da9dbe0d1a6d48.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jonathan-innis
force-pushed
the
instanceTypes
branch
from
njtran
force-pushed
the
instanceTypes
branch
2 times, most recently
from
Fixes #4848
Description
Removes the describe subnets call from the GetInstanceTypes so that we list all instance types from all availability zones in a region.
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.