Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix E2E test permissions, upgrade, consolidation, and integration tests #4880

Merged
merged 9 commits into from
Oct 23, 2023
Merged

test: Fix E2E test permissions, upgrade, consolidation, and integration tests #4880

merged 9 commits into from
Oct 23, 2023

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Oct 21, 2023 •
edited
Loading

Fixes #N/A

Description

  • This PR updates the IAM Cloudformation permissions used for the permission boundary for the GithubActions role.
  • This PR also updates test that is run during the upgrade test to be Beta/Integration
  • It updates the Monitor to handle watching nodes that are owned by NodePools so consolidation tests work
  • It updates bugs in the Integration test cases
  • It merges the Utilization test case/suite into the Integration test suite
  • The cloudformation policy had to be condensed here to avoid going over the managed instance profile character limit

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner October 21, 2023 05:26
@netlify
Copy link

netlify bot commented Oct 21, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 83c66c5
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6536c4638a87ec0008bdb1a3

@jonathan-innis jonathan-innis enabled auto-merge (squash) October 21, 2023 05:26
@jonathan-innis jonathan-innis force-pushed the fix-e2etests branch 3 times, most recently from 4a93fc0 to 8cfde75 Compare October 21, 2023 06:35
jonathan-innis
jonathan-innis commented Oct 21, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-8cfde754e56a0f5bd17f8da1021475ecce26a45e.

@jonathan-innis jonathan-innis force-pushed the fix-e2etests branch 5 times, most recently from 7b85921 to a610eb8 Compare October 22, 2023 22:34
jonathan-innis
jonathan-innis commented Oct 22, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-a610eb87010892f2f27cc65ccd1bb8c5a38fc718.

@jonathan-innis jonathan-innis force-pushed the fix-e2etests branch 4 times, most recently from 9f80b50 to ef39940 Compare October 23, 2023 06:00
@jonathan-innis jonathan-innis changed the title test: Fix E2E test permissions and Upgrade testing test: Fix E2E test permissions, upgrade, consolidation, and integration tests Oct 23, 2023
jonathan-innis
jonathan-innis commented Oct 23, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-5860e1d6035cc9b5a6bd83464eae9e58fb199cae.

jonathan-innis
jonathan-innis commented Oct 23, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-e204334f0851fa24a3debd5f5561e2a05fdb9ce2.

engedaam
engedaam approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 67ead12 into aws:main Oct 23, 2023
11 checks passed
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
@jonathan-innis @johngmyers
test: Fix E2E test permissions and Upgrade testing (aws#4880)
3fcdb6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam engedaam approved these changes

@jmdeal jmdeal Awaiting requested review from jmdeal jmdeal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathan-innis @engedaam