Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add contribution info #4882

Merged
merged 2 commits into from
Oct 22, 2023
Merged

docs: Add contribution info #4882

merged 2 commits into from
Oct 22, 2023

Conversation

dev-slatto
Copy link
Contributor

Description
As the project doesn't include the CONTRIBUTING.md, a clear guide on where to find the contribution guidelines would make it easy for developers who want to get involved with the Karpenter project.

Does this change impact docs?

  • Yes, PR includes docs updates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dev-slatto dev-slatto requested a review from a team as a code owner October 21, 2023 21:24
@netlify
Copy link

netlify bot commented Oct 21, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 41c78d7
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65344480120ccc00084e5119

@jonathan-innis
Copy link
Contributor

As the project doesn't include the CONTRIBUTING.md

I think this makes a lot of sense in the interim, though I'd like to see us have a CONTRIBUTING.md in the repo as well. I'm going to open an issue for this. @dev-slatto If you'd be interested in helping contribute that doc as well, we'd definitely welcome that contribution

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) October 22, 2023 20:18
@jonathan-innis
Copy link
Contributor

Linking #4884

@jonathan-innis jonathan-innis merged commit af6387d into aws:main Oct 22, 2023
12 checks passed
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants