Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use legacy taint logic for disruption #4896

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Oct 23, 2023

Fixes #N/A

Description
Fixes an inconsistency in logic where we were using the new v1beta1 taint logic with v1alpha APIs.

How was this change tested?
make presubmit, test with e2e

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner October 23, 2023 22:26
@njtran njtran requested a review from ellistarn October 23, 2023 22:26
@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 8068f1f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6536f2fdaa3c370008d6b7ac

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) October 23, 2023 22:26
@jonathan-innis jonathan-innis merged commit a71a5e6 into aws:main Oct 23, 2023
12 checks passed
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants