Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support vpc.amazonaws.com/efa resource #5068

Merged
merged 3 commits into from
Nov 30, 2023
Merged

feat: support vpc.amazonaws.com/efa resource #5068

merged 3 commits into from
Nov 30, 2023

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Nov 11, 2023 •
edited
Loading

Fixes #3127

Description
This PR adds support for the vpc.amazonaws.com/efa resource. No additional configuration in either the NodePool or NodeClass is required, if an unschedulable pod is requesting the resource, Karpenter will launch an EC2 instance with all possible EFAs configured.

How was this change tested?
make test & make e2etest (TODO)

TODO

  • add integration tests
  • add tests for launch template configuration

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify Netlify
Copy link

netlify bot commented Nov 11, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit af5a403
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6567d9874dd0cb0008f0ac2b

@jmdeal jmdeal added the feature New feature or request label Nov 11, 2023
@jmdeal jmdeal changed the title feat: support vpc.amazonaws.com/efa resource [DRAFT] feat: support vpc.amazonaws.com/efa resource Nov 11, 2023
@jmdeal jmdeal removed the feature New feature or request label Nov 11, 2023
@jmdeal jmdeal changed the title [DRAFT] feat: support vpc.amazonaws.com/efa resource feat: support vpc.amazonaws.com/efa resource Nov 16, 2023
@jmdeal jmdeal marked this pull request as ready for review November 16, 2023 19:28
@jmdeal jmdeal requested a review from a team as a code owner November 16, 2023 19:28
@jmdeal jmdeal requested a review from bwagner5 November 16, 2023 19:28
@jmdeal jmdeal force-pushed the no-config-efa branch 5 times, most recently from 4ec457d to 3d2152d Compare November 21, 2023 20:40
jmdeal
jmdeal commented Nov 22, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-3d2152d5f99863fe37dedb8da6d78155fecaffc2.

@jmdeal jmdeal mentioned this pull request Nov 22, 2023
Closed
3 tasks
jonathan-innis
jonathan-innis reviewed Nov 28, 2023
View reviewed changes
pkg/providers/instance/types.go Outdated Show resolved Hide resolved
pkg/cloudprovider/cloudprovider.go Show resolved Hide resolved
pkg/cloudprovider/cloudprovider.go Outdated Show resolved Hide resolved
pkg/providers/launchtemplate/launchtemplate.go Outdated Show resolved Hide resolved
pkg/providers/launchtemplate/launchtemplate.go Outdated Show resolved Hide resolved
pkg/providers/launchtemplate/launchtemplate.go Outdated Show resolved Hide resolved
pkg/providers/amifamily/resolver.go Show resolved Hide resolved
pkg/providers/amifamily/resolver.go Show resolved Hide resolved
test/suites/integration/extended_resources_test.go Show resolved Hide resolved
jmdeal
jmdeal commented Nov 29, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-5e9a4e94a005350d9f79f3a5287667eb40bfd9a8.

jmdeal
jmdeal commented Nov 29, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-a18b8625fe78999991b16d3875df62e91204508b.

jmdeal
jmdeal commented Nov 30, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

jonathan-innis
jonathan-innis previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Nice work!

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-f5d6b77e8e0575646541b0edc74b1fbfeffeacf8.

jonathan-innis
jonathan-innis approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

jmdeal
jmdeal commented Nov 30, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-af5a4031a6afd5b4807893b2267b1355b2163b51.

@jmdeal jmdeal merged commit 8eb2991 into aws:main Nov 30, 2023
21 of 23 checks passed
@jmdeal jmdeal deleted the no-config-efa branch May 9, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Elastic Fabric Adapter (EFA) to Karpenter
2 participants
@jmdeal @jonathan-innis