Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: kmsKeyID doesnt need arn prefix in NodeClass resource #5152

Merged
merged 4 commits into from
Jan 8, 2024
Merged

docs: kmsKeyID doesnt need arn prefix in NodeClass resource #5152

merged 4 commits into from
Jan 8, 2024

Conversation

Nadeshan
Copy link
Contributor

@Nadeshan Nadeshan commented Nov 24, 2023 •
edited
Loading

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Nadeshan Nadeshan requested a review from a team as a code owner November 24, 2023 06:21
@netlify Netlify
Copy link

netlify bot commented Nov 24, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 53c7821
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/659c8758f358930008c8ea20
😎 Deploy Preview https://deploy-preview-5152--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@engedaam
Copy link
Contributor

@Nadeshan do you have any updates?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@jonathan-innis jonathan-innis added needs-review PRs that are still going through the review process and removed lifecycle/stale labels Jan 4, 2024
engedaam
engedaam approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam removed the needs-review PRs that are still going through the review process label Jan 8, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7454528233

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.547%
Totals Coverage Status
Change from base Build 7453106604: 0.02%
Covered Lines: 4952
Relevant Lines: 5999
💛 - Coveralls

@engedaam engedaam merged commit e7bcf54 into aws:main Jan 8, 2024
14 checks passed
@engedaam engedaam mentioned this pull request Jan 9, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhammedsherief muhammedsherief muhammedsherief left review comments

@shabbskagalwala shabbskagalwala shabbskagalwala left review comments

@jonathan-innis jonathan-innis jonathan-innis left review comments

@engedaam engedaam engedaam approved these changes

Assignees

@engedaam engedaam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Nadeshan @engedaam @coveralls @jonathan-innis @shabbskagalwala @muhammedsherief