Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add label selector to workload topology spread constraint example #5174

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Nov 28, 2023

Fixes #N/A

Description
This PR adds the labelSelector field to the topology spread constraint example under advanced scheduling in the docs. Although it opts to not define a selector, indicating that the field should exist avoid confusion in issues like #5171.

How was this change tested?
N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner November 28, 2023 02:03
@jmdeal jmdeal requested a review from bwagner5 November 28, 2023 02:03
Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 3117fd4
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65664de65448a4000813405a
😎 Deploy Preview https://deploy-preview-5174--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jmdeal jmdeal linked an issue Nov 28, 2023 that may be closed by this pull request
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 8bbc545 into aws:main Nov 28, 2023
12 checks passed
@jmdeal jmdeal deleted the topology-spread-doc-update branch December 4, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On-Demand/Spot Ratio Split now working (always get spot only)
2 participants