Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run karpenter by default in the kube-system namespace #5192

Merged

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Nov 30, 2023

Fixes #N/A

Description

This change updates the Makefile and our CI testing to run Karpenter in the default namespace recommended by the docs, the kube-system namespace. More details on why we decided to change to this recommendation as the default namespace is covered here: #5124

How was this change tested?

make presubmit
/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 75c31f4
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6567da21dbed3d000882a563

Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-75c31f4435327ee5157207be6a3c53dd38b41872.

@jonathan-innis jonathan-innis marked this pull request as ready for review November 30, 2023 17:37
@jonathan-innis jonathan-innis requested a review from a team as a code owner November 30, 2023 17:37
@jonathan-innis jonathan-innis changed the title chore: Run karpenter by default in the kube-system namespace ci: Run karpenter by default in the kube-system namespace Nov 30, 2023
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 3522382 into aws:main Nov 30, 2023
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants