Test: Docker image for tests #5193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committer: Aman Agrawal <[email protected]>
✅ Deploy Preview for karpenter-docs-prod canceled.
|
test/Dockerfile
Outdated
| @@ -59,4 +60,7 @@ RUN go version | |||
| # Cache modules to speed up test execution | |||
| RUN git clone https://github.com/aws/karpenter.git /karpenter | |||
| WORKDIR /karpenter | |||
| RUN GOPROXY=direct go mod tidy | |||
|
|
|||
| RUN K8S_VERSION="1.28.x" make toolchain | |||
There was a problem hiding this comment.
Do we need to run the full make toolchain? IIRC, we should be fine just defining a subset of dependencies in this Dockerfile and then using those directly.
hack/toolchain.sh
Outdated
| @@ -3,6 +3,7 @@ set -euo pipefail | |||
|
|
|||
| K8S_VERSION="${K8S_VERSION:="1.28.x"}" | |||
| KUBEBUILDER_ASSETS="/usr/local/kubebuilder/bin" | |||
| USER=$(whoami) | |||
There was a problem hiding this comment.
What's the need for adding this to the script?
…karpenter into docker-image-for-tests
|
Discussed offline a bit. Given the state of the current code and the value prop of adding the Dockerfile, I'm more inclined to forego this change in favor of just installing some of the tooling at runtime. If we start feeling like the overhead of running all of the installs at the beginning of the E2E is too onerous, then I could see us adding this, but I'm not sure it's worth the maintenance burden right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4545
Description
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.