Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Adjust regions for metrics of resource counter and sweeper #5202

Merged
merged 1 commit into from
Dec 1, 2023
Merged

ci: Adjust regions for metrics of resource counter and sweeper #5202

merged 1 commit into from
Dec 1, 2023

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Dec 1, 2023

Fixes #N/A

Description

  • Differentiate between global and regional resources for the sweeper and counter for the metrics that are pushed to Timestream.

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner December 1, 2023 10:03
@engedaam engedaam requested a review from njtran December 1, 2023 10:03
@netlify Netlify
Copy link

netlify bot commented Dec 1, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 786e049
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/656a2f76c4c3680008a3d7ab

@engedaam engedaam force-pushed the adjust-metrics-for-resource branch 2 times, most recently from a64bf3e to fd75754 Compare December 1, 2023 19:09
jonathan-innis
jonathan-innis approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 6ac2b80 into aws:main Dec 1, 2023
12 checks passed
@engedaam engedaam deleted the adjust-metrics-for-resource branch December 1, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@njtran njtran Awaiting requested review from njtran njtran is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engedaam @jonathan-innis