Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Expect nodes to be spun up on Expiration Scale test #5227

Merged
merged 1 commit into from
Dec 5, 2023
Merged

test: Expect nodes to be spun up on Expiration Scale test #5227

merged 1 commit into from
Dec 5, 2023

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Dec 5, 2023

Fixes #N/A

Description

  • Scale tests were failing as expired nodes were not being validated to see if the new nodes were properly launched and cleanup. This was impacting the next test.

How was this change tested?

  • Manually tested

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner December 5, 2023 00:19
@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 1e0b574
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/656e6f4628003900089d46bb
😎 Deploy Preview https://deploy-preview-5227--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jonathan-innis
jonathan-innis approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional comment

test/suites/scale/deprovisioning_test.go Show resolved Hide resolved
@engedaam engedaam enabled auto-merge (squash) December 5, 2023 20:51
@engedaam engedaam merged commit 80609d7 into aws:main Dec 5, 2023
12 checks passed
@engedaam engedaam deleted the fix-expiration-scale-testing branch December 5, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@ellistarn ellistarn Awaiting requested review from ellistarn ellistarn is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engedaam @jonathan-innis