Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify amiSelector overriding default amis in amiFamily #5412

Merged

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

This adds a clarifying statement about the amiSelector overriding the default amis selected-on by the amiFamily in the spec.amiSelector section of the docs

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner January 1, 2024 20:26
Copy link

netlify bot commented Jan 1, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 3f0c244
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6593226603c8ae000840673f
😎 Deploy Preview https://deploy-preview-5412--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7379824634

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.547%

Totals Coverage Status
Change from base Build 7379018374: 0.0%
Covered Lines: 4952
Relevant Lines: 5999

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit d2c8c09 into aws:main Jan 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants