Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add IRSA Annotation for k8s 1.23 Karpenter Deployment #5445

Merged
merged 3 commits into from
Jan 10, 2024
Merged

ci: Add IRSA Annotation for k8s 1.23 Karpenter Deployment #5445

merged 3 commits into from
Jan 10, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • For k8s 1.23, the E2E test relay on IRSA instead of pod identity. Therefore, the karpenter service account will need the karpenter role name annotated

How was this change tested?

  • Forked account

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner January 10, 2024 01:11
@netlify Netlify
Copy link

netlify bot commented Jan 10, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 96495af
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/659deebec01f860008138616

@netlify Netlify
Copy link

netlify bot commented Jan 10, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 3160491
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/659ef6dd770a0f0008ad19f3

@engedaam engedaam changed the title ci: Add IRSA Annotation for k8s 1.23 ci: Add IRSA Annotation for k8s 1.23 Karpenter Deployment Jan 10, 2024
@coveralls
Copy link

coveralls commented Jan 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7480114431

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 82.53%
Totals Coverage Status
Change from base Build 7478688292: -0.02%
Covered Lines: 4951
Relevant Lines: 5999
💛 - Coveralls

@engedaam engedaam force-pushed the add_sa_to_karpenter_for_irsa branch 3 times, most recently from 8d87224 to 15f3749 Compare January 10, 2024 19:58
@engedaam engedaam enabled auto-merge (squash) January 10, 2024 21:25
jmdeal
jmdeal approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 6934ef5 into aws:main Jan 10, 2024
14 checks passed
@engedaam engedaam deleted the add_sa_to_karpenter_for_irsa branch January 17, 2024 19:15
@engedaam engedaam mentioned this pull request Jan 22, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis left review comments

@njtran njtran njtran left review comments

@jmdeal jmdeal jmdeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@engedaam @coveralls @njtran @jmdeal @jonathan-innis