Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove create node permission from ClusterRole #5465

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

This change removes an unneeded Create permission on nodes that is no longer needed by Karpenter since it has been allowing kubelet to create the nodes on behalf of the instance rather than Karpenter orchestrating the Node creation directly

How was this change tested?

/karpenter snapshot
make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner January 12, 2024 18:47
Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 2282981
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65a1895f2482940008a5ec03
😎 Deploy Preview https://deploy-preview-5465--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7506213962

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.547%

Totals Coverage Status
Change from base Build 7496532085: 0.0%
Covered Lines: 4952
Relevant Lines: 5999

💛 - Coveralls

Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-2282981fea56eafa5b273b893bafcf56bbc8a212.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

@jonathan-innis jonathan-innis merged commit 83c3083 into aws:main Jan 12, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants