Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing for consolidation budgets e2e #5525

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Add testing for consolidation budgets e2e #5525

merged 3 commits into from
Jan 26, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify Netlify
Copy link

netlify bot commented Jan 25, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 90a040e
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65b2f969212fda0008644cd6

jonathan-innis
jonathan-innis commented Jan 25, 2024
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@coveralls
Copy link

coveralls commented Jan 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7662101915

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.599%
Totals Coverage Status
Change from base Build 7660430445: 0.0%
Covered Lines: 5003
Relevant Lines: 6057
💛 - Coveralls

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-e350ba085bbc5bca3ce5c2d9e6b5ffe15408138f.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

jonathan-innis
jonathan-innis commented Jan 25, 2024
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-4b6a4b4a51a8846d7e8efa96a61dc586a1665771.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

jonathan-innis
jonathan-innis commented Jan 25, 2024
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-337eab311d39b6c9199513b73b8aeb37cf20c8be.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

jonathan-innis
jonathan-innis commented Jan 25, 2024
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-a8bc7dcc0af23aaf765ebe78e9d2d9f3c6f3f7fd.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

njtran
njtran reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for doing this!

test/pkg/environment/common/expectations.go Show resolved Hide resolved
test/pkg/environment/common/expectations.go Show resolved Hide resolved
test/pkg/environment/common/expectations.go Show resolved Hide resolved
test/pkg/environment/common/expectations.go Show resolved Hide resolved
test/pkg/environment/common/expectations.go Show resolved Hide resolved
test/pkg/environment/common/expectations.go Outdated Show resolved Hide resolved
test/suites/consolidation/suite_test.go Outdated Show resolved Hide resolved
test/suites/consolidation/suite_test.go Outdated Show resolved Hide resolved
test/suites/consolidation/suite_test.go Show resolved Hide resolved
test/suites/drift/suite_test.go Show resolved Hide resolved
@jonathan-innis jonathan-innis force-pushed the consolidation-budgets-testing branch 3 times, most recently from 85050d3 to 6c9fc70 Compare January 25, 2024 23:22
@jonathan-innis jonathan-innis changed the title [WIP] Add testing for consolidation budgets e2e Add testing for consolidation budgets e2e Jan 26, 2024
@jonathan-innis jonathan-innis marked this pull request as ready for review January 26, 2024 00:08
@jonathan-innis jonathan-innis requested a review from a team as a code owner January 26, 2024 00:08
jonathan-innis
jonathan-innis commented Jan 26, 2024
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-90a040e8bca05d689058a6bfba26bd3e5eee96e5.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

njtran
njtran reviewed Jan 26, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis merged commit 0be1ea7 into aws:main Jan 26, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran approved these changes

@ljosyula ljosyula Awaiting requested review from ljosyula ljosyula is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @njtran