Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(chart): Added Artifact Hub config support #5608

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

stevehipwell
Copy link
Contributor

Related to #5306

Description
This PR adds the ability to add Artifact Hub metadata to the chart OCI registry once the organisation and repos have been created (see #5306).

This PR has been split out of #5561.

How was this change tested?
Ad-hoc (I use this pattern for all of my Helm charts).

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@stevehipwell stevehipwell requested a review from a team as a code owner February 6, 2024 10:03
Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit f0fe34a
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65cee6a363fd780008bcb40c

@stevehipwell
Copy link
Contributor Author

CC @jonathan-innis.

@stevehipwell stevehipwell marked this pull request as ready for review February 6, 2024 10:06
@stevehipwell stevehipwell force-pushed the helm-repo-ah-config branch 5 times, most recently from 4f2990c to f4d479d Compare February 13, 2024 17:36
jonathan-innis
jonathan-innis previously approved these changes Feb 16, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) February 16, 2024 04:26
@coveralls
Copy link

coveralls commented Feb 16, 2024

Pull Request Test Coverage Report for Build 7926108598

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.514%

Totals Coverage Status
Change from base Build 7926094444: 0.02%
Covered Lines: 5016
Relevant Lines: 6079

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit bddd3c0 into aws:main Feb 16, 2024
16 checks passed
@stevehipwell stevehipwell deleted the helm-repo-ah-config branch February 16, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants