-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(chart): Added Artifact Hub config support #5608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
stevehipwell
force-pushed
the
helm-repo-ah-config
branch
from
February 6, 2024 10:06
6f2d623
to
c5ffa22
Compare
CC @jonathan-innis. |
stevehipwell
force-pushed
the
helm-repo-ah-config
branch
5 times, most recently
from
February 13, 2024 17:36
4f2990c
to
f4d479d
Compare
stevehipwell
force-pushed
the
helm-repo-ah-config
branch
from
February 14, 2024 09:15
f4d479d
to
a2f8cea
Compare
jonathan-innis
previously approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Pull Request Test Coverage Report for Build 7926108598Details
💛 - Coveralls |
Signed-off-by: Steve Hipwell <[email protected]>
jonathan-innis
force-pushed
the
helm-repo-ah-config
branch
from
February 16, 2024 04:37
a2f8cea
to
f0fe34a
Compare
jonathan-innis
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5306
Description
This PR adds the ability to add Artifact Hub metadata to the chart OCI registry once the organisation and repos have been created (see #5306).
This PR has been split out of #5561.
How was this change tested?
Ad-hoc (I use this pattern for all of my Helm charts).
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.