-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Fix E2E test for release-v0.31.x
#5639
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engedaam
changed the title
test: Fix E2E test for release-v0.32.x
test: Fix E2E test for release-v0.31.x
Feb 9, 2024
engedaam
changed the title
test: Fix E2E test for release-v0.31.x
test: Fix E2E test for Feb 9, 2024
release-v0.31.x
jmdeal
previously approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Pull Request Test Coverage Report for Build 7838083854
💛 - Coveralls |
engedaam
force-pushed
the
fix-e2e-tests
branch
from
February 9, 2024 00:54
dde532a
to
74d2a0a
Compare
jmdeal
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
johngmyers
pushed a commit
to johngmyers/karpenter
that referenced
this pull request
May 31, 2024
johngmyers
added a commit
to johngmyers/karpenter
that referenced
this pull request
May 31, 2024
Merge in DEL/karpenter-fork from upgrade-31-4 to main * commit '4f1e7c0ea99fb9fb5399fb3178cb054ba4210869': chore: Bump karpenter for v0.31.4 (aws#5641) test: Fix E2E test for `release-v0.31.x` (aws#5639) ci: Adding `contents` permission to E2E testing for `release-v0.31.x` (aws#5635) ci: Fix permission on E2E for the `release-v0.31.x` (aws#5634) ci: Port workflow fixes for `release-v0.31.x` (aws#5627) ci: Add trigger release branch (aws#5626) ci: Allow ci to run on `release-v0.31.x` (aws#5625) fix: Fix retrieving NodePool when rolling back to v0.31.x (aws#5621) chore: release v0.31.3 (aws#5206)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.