Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump go version to 1.22 #5653

Merged
merged 2 commits into from
Mar 12, 2024
Merged

deps: bump go version to 1.22 #5653

merged 2 commits into from
Mar 12, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Feb 12, 2024

Fixes #N/A

Description
Bumps go to the latest release: release notes

Justification for pinning to the patch version: golang/go#62278

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner February 12, 2024 19:09
@coveralls
Copy link

coveralls commented Feb 12, 2024

Pull Request Test Coverage Report for Build 8252921812

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 82.342%

Totals Coverage Status
Change from base Build 8245150615: -0.4%
Covered Lines: 5302
Relevant Lines: 6439

💛 - Coveralls

@jmdeal jmdeal added the blocked Unable to make progress due to some dependency label Feb 12, 2024
@jmdeal
Copy link
Contributor Author

jmdeal commented Feb 12, 2024

Blocked on an apparent issue with govulncheck: golang/go#65590.

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 8b5090f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65f08bd1b45b700008cb842b

@jmdeal jmdeal force-pushed the bump-go-1.22 branch 2 times, most recently from a92564e to 43a55af Compare March 11, 2024 18:14
@jmdeal jmdeal removed the blocked Unable to make progress due to some dependency label Mar 11, 2024
@jmdeal jmdeal force-pushed the bump-go-1.22 branch 2 times, most recently from f906a03 to b7856ff Compare March 11, 2024 18:23
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-63473f9f7dfabc26de73967d2860e453f8acf5cb.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-63473f9f7dfabc26de73967d2860e453f8acf5cb" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal enabled auto-merge (squash) March 12, 2024 17:14
@jmdeal jmdeal merged commit 63be9d6 into aws:main Mar 12, 2024
17 checks passed
@jmdeal jmdeal deleted the bump-go-1.22 branch May 9, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants